chore: use bench array helpers from Arrow bench_util#21544
chore: use bench array helpers from Arrow bench_util#21544theirix wants to merge 3 commits intoapache:mainfrom
Conversation
# Conflicts: # datafusion/functions-nested/benches/array_remove.rs
|
run benchmarks array_agg array_min_max array_remove array_repeat array_to_string |
|
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing use-bench-utils (2112144) to 3911f0c (merge-base) diff File an issue against this benchmark runner |
|
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing use-bench-utils (2112144) to 3911f0c (merge-base) diff File an issue against this benchmark runner |
|
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing use-bench-utils (2112144) to 3911f0c (merge-base) diff File an issue against this benchmark runner |
|
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing use-bench-utils (2112144) to 3911f0c (merge-base) diff File an issue against this benchmark runner |
|
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing use-bench-utils (2112144) to 3911f0c (merge-base) diff File an issue against this benchmark runner |
|
Benchmark for this request failed. Last 20 lines of output: Click to expandFile an issue against this benchmark runner |
|
🤖 Criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
@theirix could you look into this, if this failure is related? |
|
🤖 Criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
that's strange, because running |
Which issue does this PR close?
Rationale for this change
While working on function benchmarks, I've noticed duplicated code, which can be replaced with arrow::util::bench_util helpers. I recall a discussion in apache/arrow-rs#7294 about bench_util / test_utils usage, and seems like it can be used to simplify clients code.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?